Home » excel » excel vba – How to increment values in one column with the reference of value in another column

excel vba – How to increment values in one column with the reference of value in another column

Posted by: admin April 23, 2020 Leave a comment

Questions:

i want to add n cells in column C and D, where n is value in column B

My Code is:

Sub mycode()
Dim lastrow1 As Long
    lastrow1 = Range("A" & Rows.Count).End(xlUp).Row

Dim lastrow2 As Long
    lastrow2 = Range("C" & Rows.Count).End(xlUp).Row

For h = 2 To lastrow1
    For i = 2 To lastrow2
        If Sheet1.Cells(h, 1).Value = Sheet1.Cells(i, 3).Value Then
            P = 10
            t = i + 1
                For j = 1 To Cells(i, 2).Value
                    Sheet1.Cells(t, 3).Insert shift:=xlDown
                    Sheet1.Cells(t, 4).Insert shift:=xlDown
                    Sheet1.Cells(t, 3).Value = Sheet1.Cells(i, 3).Value
                    Sheet1.Cells(t, 4).Value = Sheet1.Cells(i, 4).Value + P
                    P = P + 10
                    t = t + 1
                Next j
        End If
     Next i
Next h
End Sub

Sample Input 1 :

Input

After running above code, output is

Output after running macro

Problem:
Now when i add second entry in row 3 and run code something is going wrong:

Input:

enter image description here

Wrong output generated by code:

enter image description here

Correct output should be:

enter image description here

I am unable to get where my code is going wrong.
Please help.

EDITED:
sample 2:
Input:

enter image description here

Output:

enter image description here

How to&Answers:

I edited your code and added comments.

Updated code:

Sub mycode()
Application.ScreenUpdating = False 'Optional speedup code
Dim lastrow1 As Long
lastrow1 = Range("B" & Rows.Count).End(xlUp).Row
Dim Inputs() As Variant         'Create an array to hold positions
ReDim Inputs(lastrow1 - 1)      'Make it big enough to hold all positions
For x = 2 To lastrow1           'For each Position
    Inputs(x - 1) = Cells(x, 4) 'Store The Position
Next x
OutRow = 2      'Row to output to
Increment = 10  'Increment
For Each c In Range("B2:B" & lastrow1) 'For each "count"
    For j = 0 To c.Value
        Cells(OutRow, 3).Value = c.Offset(0, -1).Value 'Put the letter in column C
        If j = 0 Then  'If it's the first new letter, start at the position
            Cells(OutRow, 4).Value = Inputs(c.Row - 1)
        Else 'Otherwise, just add our increment to the number above
            Cells(OutRow, 4).Value = Cells(OutRow - 1, 4).Value + Increment
        End If
        OutRow = OutRow + 1
    Next j
Next c
Application.ScreenUpdating = True 'Optional speedup code
End Sub

Final output:

Pic4